Use constants for Vert.x web route order marks #35917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @cescoffier |
quarkus-bot
bot
added
area/documentation
area/resteasy-classic
area/rest
area/vertx
labels
mkouba
reviewed
Sep 15, 2023
mkouba
reviewed
Sep 15, 2023
cescoffier
requested changes
Sep 18, 2023
snazy
force-pushed
the
route-order-constants
branch
from
db9469a to
74ec436
Compare
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
route-order-constants
branch
from
74ec436 to
8e6064f
Compare
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
|
@mkouba @cescoffier could you have another look? |
mkouba
reviewed
Sep 22, 2023
As discussed in quarkusio#35513 it is beneficial to have the route order marks defined as constants. This change introduces a class containing nearly all these constants, except the extension specific values.
snazy
force-pushed
the
route-order-constants
branch
from
8e6064f to
938d9e3
Compare
mkouba
added
the
triage/waiting-for-ci
cescoffier
approved these changes
Oct 2, 2023
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #35513 it is beneficial to have the route order marks defined as constants.
This change introduces a class containing nearly all these constants, except the extension specific values.